[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] allow user-configurable menucolor

From: Yoshinori K. Okuji
Subject: Re: [PATCH] allow user-configurable menucolor
Date: Thu, 3 Jan 2008 00:42:01 +0100
User-agent: KMail/1.9.4

On Tuesday 01 January 2008 13:47, Robert Millan wrote:
> This patch allows the following to work:
>   set color_normal=cyan/blue
>   set color_highlight=white/blue

Although I am not a native speaker, I feel that they should be better 
called "normal_color" and "highlight_color".

> which is equivalent to this command in GRUB Legacy:
>   color cyan/blue white/blue
> I haven't written a ChangeLog entry yet, because I'd like to receive
> comments on the function names.  I don't really like
> `parse_single_color_name' and `parse_color_name' but I don't know what to
> call them :-(.  What conventions are there for referring to single colors
> (i.e. those that describe only FG or only BG, not both) and complete colors
> (FG + BG) ?

No such word, AFAIK. You know, it is ugly, because you want to put two 
separate things into one place. ;)

Just look at CSS...

div {
  color: black;
  background-color: white;

So, if you don't hesitate to create so many variables, you can simply 
create "normal_color", "normal_background_color", "highlight_color" 
and "highlight_background_color", although I don't know who would like it.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]