[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] memtest86+ fix
From: |
Yoshinori K. Okuji |
Subject: |
Re: [PATCH] memtest86+ fix |
Date: |
Thu, 3 Jan 2008 00:46:15 +0100 |
User-agent: |
KMail/1.9.4 |
On Wednesday 02 January 2008 18:05, Robert Millan wrote:
> This fixes boot for memtest86+ (and actually, Linux zImages since they were
> all affected).
>
> The problem was that the first code in grub_linux_boot_zimage copied the
> payload from 0x100000 to 0x10000. Since GRUB starts at 0x8200 and is
> typicaly more than 8 kiB in size, it'll most likely overwrite part of it.
>
> A bit of reestructuring was necessary to allow grub_dl_unload_all() to
> happen unconditionally as first step, since the information on whether this
> is a "big linux" was not promptly available.
>
> Comments?
It is okay, except for "grub_linux_big"... I cannot figure out what it wants
to say. As you want to make it global, please choose a more expressive name,
such as "grub_big_linux_loaded".
Okuji
- [PATCH] memtest86+ fix, Robert Millan, 2008/01/02
- Re: [PATCH] memtest86+ fix,
Yoshinori K. Okuji <=
- Re: [PATCH] memtest86+ fix, Robert Millan, 2008/01/02
- Re: [PATCH] memtest86+ fix, Yoshinori K. Okuji, 2008/01/04
- Re: [PATCH] memtest86+ fix, Pavel Roskin, 2008/01/04
- Re: [PATCH] memtest86+ fix, Robert Millan, 2008/01/05
- Re: [PATCH] memtest86+ fix, Yoshinori K. Okuji, 2008/01/05
- Re: [PATCH] memtest86+ fix, Robert Millan, 2008/01/05