gnu-arch-users
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Gnu-arch-users] [BUG] tla import produces Added-Files incorrectly


From: David Allouche
Subject: [Gnu-arch-users] [BUG] tla import produces Added-Files incorrectly
Date: Tue, 17 Aug 2004 10:34:50 +0100
User-agent: Mutt/1.5.6+20040523i

"tla import" incorrectly generates the New-files patchlog header without
taking explicit id tags into account.

On Mon, Aug 16, 2004 at 10:34:23PM +0000, Mikhael Goikhman wrote:
> On 16 Aug 2004 11:54:44 -0700, Tom Lord wrote:
> > 
> >     > From: David Allouche <address@hidden>
> > 
> >     > I have just found that when explicit id-tags are used, the
> >     > patchlog header "New-files" does not mention explicit id-tags,
> >     > but the "Removed-files" headers does mention them.
> 
> Both New-files and Removed-files headers obviously include .arch-ids/
> files. The problem is only with import that indeed should be fixed.
> 
> Here is, for example, a page generated from a non-import log:
> 
>   http://archzoom.sourcecontrol
>   .net/demo/address@hidden/archzoom--devel--0--patch-49?log
> 
> >     > I have not checked the way Moved-files (or whatever the name
> >     > of the header summarizing renames) behaves with respect to
> >     > explicit id-tags since it is not (yet) supported by PyArch and
> >     > my current priority is upgrading the _existing_ functionality
> >     > to support file name escaping.
> 
> Renamed-files include .arch-ids/ files as expected, see the same page.
> 
> >     > I _can_ write a workaround for the inconsistence if the
> >     > correct behaviour would be not to show explicit id-tags ever
> >     > in patchlogs, so I would like to know what _is_ the correct
> >     > behaviour.
> > 
> > These headers are not heavily used.  Their primary use is, for human
> > consumption (e.g., grep for a filename).
> > 
> > Therefore, I think, the explicit id files can be safely omitted from
> > the headers.
> 
> Please don't reduce the log information, fix the import log instead.

-- 
                                                            -- ddaa




reply via email to

[Prev in Thread] Current Thread [Next in Thread]