Re: feature/package-vc has been merged

[Philip Kaludercic]

Rudolf Adamkovič <salutis@me.com> writes:

>> The documentation string tries to clarify what is does, but perhaps
>> the name is confusing:
>>
>>       "Refresh the installation for package given by PKG-DESC.
>>     Refreshing an installation means scraping for new autoload
>>     cookies, re-compiling Emacs Lisp files, building and installing
>>     any documentation, downloading any missing dependencies.  This
>>     command does not fetch new revisions from a remote server.  That
>>     is the responsibility of `package-vc-update'.  Interactively,
>>     prompt for the name of the package to refresh."
>>
>> Reload?  Regenerate?  Redo?
>
> So good!  The documentation before said that it refreshes the given
> package.  Hence, I kept scratching my head.  Now, it all makes sense.
>
> As for the name, how about rebuild?  All those steps normally happen
> during a build process.  I think "refresh" sounds much too close to
> "update".

That sounds good, I'll rename it to `package-vc-rebuild'.  Thanks!

>>>    Oh, the list!  Change the configuration again:
>>>
>>>      (with-eval-after-load 'package-vc
>>>        (add-to-list 'package-vc-selected-packages '(modus-themes)))
>>>
>>>    Restart Emacs.
>>
>> Two ways to resolve this: Either throw an error earlier, which might
>> be annoying but the right thing™, or dwim and accept that the value
>> might not be readable in ECI.
>
> Early or late, we need to show at least the traditional Emacs type
> predicate error.  I say that because it took me ten minutes to find the
> problem. :)

I am still confused as to how the error came about in the first place

     user-error: Unknown package to fetch: nil

This means that `package-vc-install' was invoked with nil for
NAME-OR-URL, right?  I suspect that the condition in

  (unless (and name (package-installed-p name) (package-vc-p pkg-desc)) ...)
  
`package-vc-install-selected-packages' could be at fault here.  I will
think about it...

>>> I could not find `package-vc-update-all' akin `package-update-all'.
>>> Not that I needed it, but I looked for it in the case I manage to
>>> install more packages.
>>
>> It doesn't exist.  My idea was that package-update-all would handle
>> that, but there might be a value in a command that only updates source
>> packages?
>
> I think that would make sense.

OK, I'll add it then.

>>> The `package-vc-selected-packages' documentation [...]
>>
>> As mentioned above there are a few commits I haven't been able to push
>> because emacs.git is preventing me from force pushing.  I'll try to
>> get them up there some other way, and then rewrite the history before
>> rebasing the changes onto master.
>
> So much for "scratch" branches. :-/

I am not sure what you mean?  The issue has since been resolved.