speechd-discuss
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] rearrange code in intl sub directory


From: Andrei Kholodnyi
Subject: [PATCH] rearrange code in intl sub directory
Date: Mon, 13 Sep 2010 01:00:26 +0200

Thanks Chris.
I do remember I have written it, but it was more than month ago.

> 1) TFDSetElement, TFDSetClientSpecific, SPDMsgSettings and
> str2intpriority is specific to the server and should not be moved
> to src/common/ but somewhere to src/server/.

Yes, I agree it makes sense to move str2intpriority to src/server
SPDMsgSettings were moved to module_util.h now.
I do not think it is correct, since it is used in server and modules.
Pls. take a look into OTTS_MsgSettings
We could probably move it back later on?

> 2- 4)
Agree.

Well, you see it shall be at least 4 patches :D
All these important considerations which were mentioned by Hynek are
not reflected in the patch description.

William,
would it be possible to put more detailed description of the patch:

- why fdset.h is renamed speechd_types.h
- why FDSet specific definitions are moved to speechd.h
- why SPDMsgSettings is moved to module_utils.h
- why def.h is removed
- why str2intpriority is moved

Then I have no objections to commit it.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]