speechd-discuss
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] rearrange code in intl sub directory


From: Andrei Kholodnyi
Subject: [PATCH] rearrange code in intl sub directory
Date: Mon, 13 Sep 2010 22:56:29 +0200

>> Yes, I agree it makes sense to move str2intpriority to src/server
>
> I want to rethink this again, because it is a conversion function, and
> it could just as easily be left in the common library so it could be
> used by the modules if they need to use it.

up to you, I'm ok with both solutions

>> SPDMsgSettings were moved to module_util.h now.
>> I do not think it is correct, since it is used in server and modules.
>
> Actually it is used in the modules only.
>
> Do a "git grep SPDMsgSettings" and you will see it
> in the modules and mentioned in the documentation.

I agree, strictly speaking your decision is correct

>> Pls. take a look into OTTS_MsgSettings
>> We could probably move it back later on?
>
> ?I looked at it briefly, but I'm not sure what we were doing with it in
> ?the server of OpenTTS. ?What I would say is, let's not worry about that
> ?until we need it. ?If we decide we do, we can pull the typedef out of
> ?module_utils.h and put it in speechd_types.h.

agree, we can do it later if we need.

>> William,
>> would it be possible to put more detailed description of the patch:
>
> ?I will send this back to the list once I have it reworked. ?After
> ?getting away from it for a while, I can see that it may be able to be
> ?broken up into several patches.

and this is just great. many thanks, William.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]