speechd-discuss
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] rearrange code in intl sub directory


From: Andrei Kholodnyi
Subject: [PATCH] rearrange code in intl sub directory
Date: Sun, 12 Sep 2010 23:51:16 +0200

Hi William,

Some questions/remarks from my side.

Why have you removed def.h? I'd like rather to keep it and rename to
speechd_defaults.h
This was a place to keep default values for speech dispatcher, there
are tons of them flying around a source code.
Now you have in two places the same define
#define SPEECHD_DEFAULT_PORT 6560

why you have moved str2intpriority(char* str) into config.c?
it is a conversion function, and has nothing to do with configuration.

@c  LocalWords:  src struct gchar gint const OutputModule intl FDSetElement len
@c  LocalWords:  fdset init flite deffn TFDSetElement var int enum EVoiceType
intl and fdset shall be removed from here.

patch still does not fully describe what it does. It also
- update documentation
- rename fdset.h to speechd_types.h, not explained why
- remove def.h, not explained why
- move some pieces of fdset.h to module_utils.h, not explained why
- move some pieces of fdset.h to speechd.h, not explained why

And it is way too big.
This patch is quite easy to split into 4 separate patches.
I have attached my proposal to this email.

Would you mind dropping a look into it and tell what do you think?

Many thanks,
Andrei.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-moved-fdsetconv.c-from-intl-to-src-common-and-turn-i.patch
Type: text/x-patch
Size: 17074 bytes
Desc: not available
URL: 
<http://lists.freebsoft.org/pipermail/speechd/attachments/20100912/93916d88/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-intl-dir-renamed-to-include.patch
Type: text/x-patch
Size: 23924 bytes
Desc: not available
URL: 
<http://lists.freebsoft.org/pipermail/speechd/attachments/20100912/93916d88/attachment-0005.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-rename-fdset.h-to-speechd_types.h.patch
Type: text/x-patch
Size: 17683 bytes
Desc: not available
URL: 
<http://lists.freebsoft.org/pipermail/speechd/attachments/20100912/93916d88/attachment-0006.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-rename-def.h-to-speech_defaults.h.patch
Type: text/x-patch
Size: 6320 bytes
Desc: not available
URL: 
<http://lists.freebsoft.org/pipermail/speechd/attachments/20100912/93916d88/attachment-0007.bin>


reply via email to

[Prev in Thread] Current Thread [Next in Thread]