[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 7/9] tests: Clean up wait for event
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH 7/9] tests: Clean up wait for event |
Date: |
Tue, 25 Jul 2017 15:08:02 +0100 |
User-agent: |
Mutt/1.8.3 (2017-05-23) |
On Fri, Jul 21, 2017 at 03:53:24PM +0200, Markus Armbruster wrote:
> We still use hacks like qmp("") to wait for an event, even though we
> have qmp_eventwait() since commit 8fe941f, and qmp_eventwait_ref()
> since commit 7ffe312. Both commits neglected to convert all the
> existing hacks. Make up what they missed.
>
> Bonus: gets rid of empty format strings. A step towards compile-time
> format string checking without triggering -Wformat-zero-length.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> tests/boot-order-test.c | 2 +-
> tests/libqos/pci-pc.c | 6 +-----
> tests/tco-test.c | 3 +--
> tests/usb-hcd-uhci-test.c | 6 +-----
> tests/usb-hcd-xhci-test.c | 12 ++----------
> tests/wdt_ib700-test.c | 35 ++++++++++-------------------------
> 6 files changed, 16 insertions(+), 48 deletions(-)
Nice!
Reviewed-by: Stefan Hajnoczi <address@hidden>
signature.asc
Description: PGP signature
- Re: [Qemu-devel] [PATCH 3/9] tests: Pass literal format strings directly to qmp_FOO(), (continued)
- [Qemu-devel] [PATCH 8/9] tests/libqtest: Clean up how we read the QMP greeting, Markus Armbruster, 2017/07/21
- [Qemu-devel] [PATCH 5/9] tests/libqos/usb: Clean up string interpolation into QMP input, Markus Armbruster, 2017/07/21
- [Qemu-devel] [PATCH 7/9] tests: Clean up wait for event, Markus Armbruster, 2017/07/21
- [Qemu-devel] [PATCH 2/9] qtest: Document calling conventions, Markus Armbruster, 2017/07/21
- [Qemu-devel] [PATCH 6/9] tests/libqos/pci: Clean up string interpolation into QMP input, Markus Armbruster, 2017/07/21