[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 8/9] tests/libqtest: Clean up how we read the QM
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [PATCH 8/9] tests/libqtest: Clean up how we read the QMP greeting |
|
Date: |
Tue, 25 Jul 2017 15:08:19 +0100 |
|
User-agent: |
Mutt/1.8.3 (2017-05-23) |
On Fri, Jul 21, 2017 at 03:53:25PM +0200, Markus Armbruster wrote:
> qtest_init() still uses the qtest_qmp_discard_response(s, "") hack to
> receive the greeting, even though we have qtest_qmp_receive() since
> commit 66e0c7b. Put it to use.
>
> Bonus: gets rid of an empty format string. A step towards
> compile-time format string checking without triggering
> -Wformat-zero-length.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> tests/libqtest.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Reviewed-by: Stefan Hajnoczi <address@hidden>
signature.asc
Description: PGP signature
- [Qemu-devel] [PATCH 0/9] tests: Clean up around qmp() and hmp(), Markus Armbruster, 2017/07/21
- [Qemu-devel] [PATCH 1/9] qtest: Avoid passing raw strings through hmp(), Markus Armbruster, 2017/07/21
- [Qemu-devel] [PATCH 3/9] tests: Pass literal format strings directly to qmp_FOO(), Markus Armbruster, 2017/07/21
- [Qemu-devel] [PATCH 8/9] tests/libqtest: Clean up how we read the QMP greeting, Markus Armbruster, 2017/07/21
- [Qemu-devel] [PATCH 5/9] tests/libqos/usb: Clean up string interpolation into QMP input, Markus Armbruster, 2017/07/21
- [Qemu-devel] [PATCH 7/9] tests: Clean up wait for event, Markus Armbruster, 2017/07/21
- [Qemu-devel] [PATCH 2/9] qtest: Document calling conventions, Markus Armbruster, 2017/07/21