[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/9] tests: Pass literal format strings directly
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH 3/9] tests: Pass literal format strings directly to qmp_FOO() |
Date: |
Tue, 25 Jul 2017 14:57:28 +0100 |
User-agent: |
Mutt/1.8.3 (2017-05-23) |
On Fri, Jul 21, 2017 at 03:53:20PM +0200, Markus Armbruster wrote:
> The qmp_FOO() take a printf-like format string. In a few places, we
> assign a string literal to a variable and pass that instead of simply
> passing the literal. Clean that up.
>
> Bonus: gets rid of non-literal format strings. A step towards
> compile-time format string checking without triggering
> -Wformat-nonliteral.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> tests/ahci-test.c | 4 +---
> tests/ide-test.c | 4 +---
> 2 files changed, 2 insertions(+), 6 deletions(-)
Reviewed-by: Stefan Hajnoczi <address@hidden>
signature.asc
Description: PGP signature
- [Qemu-devel] [PATCH 0/9] tests: Clean up around qmp() and hmp(), Markus Armbruster, 2017/07/21
- [Qemu-devel] [PATCH 1/9] qtest: Avoid passing raw strings through hmp(), Markus Armbruster, 2017/07/21
- [Qemu-devel] [PATCH 3/9] tests: Pass literal format strings directly to qmp_FOO(), Markus Armbruster, 2017/07/21
- [Qemu-devel] [PATCH 8/9] tests/libqtest: Clean up how we read the QMP greeting, Markus Armbruster, 2017/07/21
- [Qemu-devel] [PATCH 5/9] tests/libqos/usb: Clean up string interpolation into QMP input, Markus Armbruster, 2017/07/21
- [Qemu-devel] [PATCH 7/9] tests: Clean up wait for event, Markus Armbruster, 2017/07/21