[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 6/9] tests/libqos/pci: Clean up string interpola
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH 6/9] tests/libqos/pci: Clean up string interpolation into QMP input |
Date: |
Tue, 25 Jul 2017 15:06:26 +0100 |
User-agent: |
Mutt/1.8.3 (2017-05-23) |
On Fri, Jul 21, 2017 at 03:53:23PM +0200, Markus Armbruster wrote:
> Leaving interpolation into JSON to qmp() is more robust than building
> QMP input manually, as explained in the commit before previous.
>
> The case in qpci_plug_device_test() is a bit complicated: it
> interpolates several JSON object members, not just a value. Clean it
> up by passing them in as QDict rather than string, so we can leave
> interpolation to qmp() here and to qobject_from_jsonf() in callers.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> tests/ivshmem-test.c | 10 +++++-----
> tests/libqos/pci.c | 33 ++++++++++++++++++---------------
> tests/libqos/pci.h | 2 +-
> tests/virtio-blk-test.c | 5 ++++-
> 4 files changed, 28 insertions(+), 22 deletions(-)
Reviewed-by: Stefan Hajnoczi <address@hidden>
signature.asc
Description: PGP signature
- [Qemu-devel] [PATCH 7/9] tests: Clean up wait for event, (continued)
- [Qemu-devel] [PATCH 7/9] tests: Clean up wait for event, Markus Armbruster, 2017/07/21
- [Qemu-devel] [PATCH 2/9] qtest: Document calling conventions, Markus Armbruster, 2017/07/21
- [Qemu-devel] [PATCH 6/9] tests/libqos/pci: Clean up string interpolation into QMP input, Markus Armbruster, 2017/07/21
- [Qemu-devel] [PATCH 9/9] tests/libqtest: Enable compile-time format string checking, Markus Armbruster, 2017/07/21
- [Qemu-devel] [PATCH 4/9] tests: Clean up string interpolation into QMP input (simple cases), Markus Armbruster, 2017/07/21