[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag
From: |
Stefano Stabellini |
Subject: |
Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag |
Date: |
Thu, 10 Sep 2015 11:29:18 +0100 |
User-agent: |
Alpine 2.02 (DEB 1266 2009-07-14) |
CC Michael
On Thu, 10 Sep 2015, Stefano Stabellini wrote:
> On Thu, 10 Sep 2015, Chen, Tiejun wrote:
> > > xen-host-pci-device.c is only compiled if CONFIG_XEN_PCI_PASSTHROUGH
> > > was set by configure. That won't be the case on OSX or Windows, where
> > > the Xen headers don't exist.
> > >
> >
> > Okay. This actually shouldn't be enabled on Windows so what about this?
>
> I think it would be nicer to replace the pread than introducing ifdefs.
Something like:
---
Replace pread with read to avoid build breakages on Windows
Signed-off-by: Stefano Stabellini <address@hidden>
diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c
index 58a33fb..9a40429 100644
--- a/hw/pci-host/piix.c
+++ b/hw/pci-host/piix.c
@@ -774,8 +774,11 @@ static int host_pci_config_read(int pos, int len, uint32_t
val)
return -ENODEV;
}
+ if (lseek(config_fd, pos, SEEK_SET) != pos) {
+ return -errno;
+ }
do {
- rc = pread(config_fd, (uint8_t *)&val, len, pos);
+ rc = read(config_fd, (uint8_t *)&val, len);
} while (rc < 0 && (errno == EINTR || errno == EAGAIN));
if (rc != len) {
return -errno;
- [Qemu-devel] [PULL 18/19] xen/pt/msi: Add the register value when printing logging and error messages, (continued)
- [Qemu-devel] [PULL 18/19] xen/pt/msi: Add the register value when printing logging and error messages, Stefano Stabellini, 2015/09/08
- [Qemu-devel] [PULL 16/19] xen/pt: xen_host_pci_config_read returns -errno, not -1 on failure, Stefano Stabellini, 2015/09/08
- Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag, Peter Maydell, 2015/09/08
- Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag, Stefano Stabellini, 2015/09/09
- Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag, Stefano Stabellini, 2015/09/09
- Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag, Peter Maydell, 2015/09/09
- Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag, Chen, Tiejun, 2015/09/09
- Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag, Peter Maydell, 2015/09/10
- Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag, Chen, Tiejun, 2015/09/10
- Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag, Stefano Stabellini, 2015/09/10
- Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag,
Stefano Stabellini <=
- Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag, Michael S. Tsirkin, 2015/09/10
- Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag, Stefano Stabellini, 2015/09/10
- Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag, Michael S. Tsirkin, 2015/09/10
- Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag, Stefano Stabellini, 2015/09/10
- Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag, Michael S. Tsirkin, 2015/09/10
- Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag, Chen, Tiejun, 2015/09/10
- Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag, Paolo Bonzini, 2015/09/14
- Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag, Stefano Stabellini, 2015/09/15
- Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag, Paolo Bonzini, 2015/09/15
- Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag, Chen, Tiejun, 2015/09/15