[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 16/19] xen/pt: xen_host_pci_config_read returns -errn
From: |
Stefano Stabellini |
Subject: |
[Qemu-devel] [PULL 16/19] xen/pt: xen_host_pci_config_read returns -errno, not -1 on failure |
Date: |
Tue, 8 Sep 2015 18:21:17 +0100 |
From: Konrad Rzeszutek Wilk <address@hidden>
However the init routines assume that on errors the return
code is -1 (as the libxc API is) - while those xen_host_* routines follow
another paradigm - negative errno on return, 0 on success.
Reviewed-by: Stefano Stabellini <address@hidden>
Signed-off-by: Konrad Rzeszutek Wilk <address@hidden>
Signed-off-by: Stefano Stabellini <address@hidden>
---
hw/xen/xen_pt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c
index ba043e6..3b1544c 100644
--- a/hw/xen/xen_pt.c
+++ b/hw/xen/xen_pt.c
@@ -729,7 +729,7 @@ static int xen_pt_initfn(PCIDevice *d)
/* Initialize virtualized PCI configuration (Extended 256 Bytes) */
if (xen_host_pci_get_block(&s->real_device, 0, d->config,
- PCI_CONFIG_SPACE_SIZE) == -1) {
+ PCI_CONFIG_SPACE_SIZE) < 0) {
xen_host_pci_device_put(&s->real_device);
return -1;
}
--
1.7.10.4
- [Qemu-devel] [PULL 02/19] i440fx: make types configurable at run-time, (continued)
- [Qemu-devel] [PULL 02/19] i440fx: make types configurable at run-time, Stefano Stabellini, 2015/09/08
- [Qemu-devel] [PULL 06/19] xen, gfx passthrough: basic graphics passthrough support, Stefano Stabellini, 2015/09/08
- [Qemu-devel] [PULL 17/19] xen: use errno instead of rc for xc_domain_add_to_physmap, Stefano Stabellini, 2015/09/08
- [Qemu-devel] [PULL 15/19] xen/pt: Make xen_pt_msi_set_enable static, Stefano Stabellini, 2015/09/08
- [Qemu-devel] [PULL 19/19] xen/pt: Use XEN_PT_LOG properly to guard against compiler warnings., Stefano Stabellini, 2015/09/08
- [Qemu-devel] [PULL 11/19] xen, gfx passthrough: add opregion mapping, Stefano Stabellini, 2015/09/08
- [Qemu-devel] [PULL 14/19] xen/pt: Update comments with proper function name., Stefano Stabellini, 2015/09/08
- [Qemu-devel] [PULL 12/19] xen-hvm: When using xc_domain_add_to_physmap also include errno when reporting, Stefano Stabellini, 2015/09/08
- [Qemu-devel] [PULL 13/19] xen/HVM: atomically access pointers in bufioreq handling, Stefano Stabellini, 2015/09/08
- [Qemu-devel] [PULL 18/19] xen/pt/msi: Add the register value when printing logging and error messages, Stefano Stabellini, 2015/09/08
- [Qemu-devel] [PULL 16/19] xen/pt: xen_host_pci_config_read returns -errno, not -1 on failure,
Stefano Stabellini <=
- Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag, Peter Maydell, 2015/09/08
- Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag, Stefano Stabellini, 2015/09/09
- Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag, Stefano Stabellini, 2015/09/09
- Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag, Peter Maydell, 2015/09/09
- Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag, Chen, Tiejun, 2015/09/09
- Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag, Peter Maydell, 2015/09/10
- Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag, Chen, Tiejun, 2015/09/10
- Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag, Stefano Stabellini, 2015/09/10
- Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag, Stefano Stabellini, 2015/09/10
- Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag, Michael S. Tsirkin, 2015/09/10