[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag
From: |
Stefano Stabellini |
Subject: |
Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag |
Date: |
Thu, 10 Sep 2015 10:42:30 +0100 |
User-agent: |
Alpine 2.02 (DEB 1266 2009-07-14) |
On Thu, 10 Sep 2015, Chen, Tiejun wrote:
> > xen-host-pci-device.c is only compiled if CONFIG_XEN_PCI_PASSTHROUGH
> > was set by configure. That won't be the case on OSX or Windows, where
> > the Xen headers don't exist.
> >
>
> Okay. This actually shouldn't be enabled on Windows so what about this?
I think it would be nicer to replace the pread than introducing ifdefs.
> diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c
> index 58a33fb..9a1fcb9 100644
> --- a/hw/pci-host/piix.c
> +++ b/hw/pci-host/piix.c
> @@ -739,6 +739,7 @@ static const TypeInfo i440fx_info = {
> .class_init = i440fx_class_init,
> };
>
> +#ifndef _WIN32
> /* IGD Passthrough Host Bridge. */
> typedef struct {
> uint8_t offset;
> @@ -819,6 +820,7 @@ static const TypeInfo igd_passthrough_i440fx_info = {
> .instance_size = sizeof(PCII440FXState),
> .class_init = igd_passthrough_i440fx_class_init,
> };
> +#endif
>
> static const char *i440fx_pcihost_root_bus_path(PCIHostState *host_bridge,
> PCIBus *rootbus)
> @@ -861,7 +863,9 @@ static const TypeInfo i440fx_pcihost_info = {
> static void i440fx_register_types(void)
> {
> type_register_static(&i440fx_info);
> +#ifndef _WIN32
> type_register_static(&igd_passthrough_i440fx_info);
> +#endif
> type_register_static(&piix3_pci_type_info);
> type_register_static(&piix3_info);
> type_register_static(&piix3_xen_info);
>
> Thanks
> Tiejun
>
- [Qemu-devel] [PULL 13/19] xen/HVM: atomically access pointers in bufioreq handling, (continued)
- [Qemu-devel] [PULL 13/19] xen/HVM: atomically access pointers in bufioreq handling, Stefano Stabellini, 2015/09/08
- [Qemu-devel] [PULL 18/19] xen/pt/msi: Add the register value when printing logging and error messages, Stefano Stabellini, 2015/09/08
- [Qemu-devel] [PULL 16/19] xen/pt: xen_host_pci_config_read returns -errno, not -1 on failure, Stefano Stabellini, 2015/09/08
- Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag, Peter Maydell, 2015/09/08
- Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag, Stefano Stabellini, 2015/09/09
- Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag, Stefano Stabellini, 2015/09/09
- Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag, Peter Maydell, 2015/09/09
- Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag, Chen, Tiejun, 2015/09/09
- Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag, Peter Maydell, 2015/09/10
- Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag, Chen, Tiejun, 2015/09/10
- Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag,
Stefano Stabellini <=
- Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag, Stefano Stabellini, 2015/09/10
- Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag, Michael S. Tsirkin, 2015/09/10
- Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag, Stefano Stabellini, 2015/09/10
- Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag, Michael S. Tsirkin, 2015/09/10
- Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag, Stefano Stabellini, 2015/09/10
- Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag, Michael S. Tsirkin, 2015/09/10
- Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag, Chen, Tiejun, 2015/09/10
- Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag, Paolo Bonzini, 2015/09/14
- Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag, Stefano Stabellini, 2015/09/15
- Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag, Paolo Bonzini, 2015/09/15