[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag
From: |
Stefano Stabellini |
Subject: |
Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag |
Date: |
Tue, 15 Sep 2015 10:55:45 +0100 |
User-agent: |
Alpine 2.02 (DEB 1266 2009-07-14) |
On Mon, 14 Sep 2015, Paolo Bonzini wrote:
> On 10/09/2015 12:29, Stefano Stabellini wrote:
> > + if (lseek(config_fd, pos, SEEK_SET) != pos) {
> > + return -errno;
> > + }
> > do {
> > - rc = pread(config_fd, (uint8_t *)&val, len, pos);
> > + rc = read(config_fd, (uint8_t *)&val, len);
> > } while (rc < 0 && (errno == EINTR || errno == EAGAIN));
>
> This leaks config_fd.
I don't follow, it leaks config_fd where?
- Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag, (continued)
- Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag, Chen, Tiejun, 2015/09/10
- Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag, Stefano Stabellini, 2015/09/10
- Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag, Stefano Stabellini, 2015/09/10
- Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag, Michael S. Tsirkin, 2015/09/10
- Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag, Stefano Stabellini, 2015/09/10
- Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag, Michael S. Tsirkin, 2015/09/10
- Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag, Stefano Stabellini, 2015/09/10
- Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag, Michael S. Tsirkin, 2015/09/10
- Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag, Chen, Tiejun, 2015/09/10
- Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag, Paolo Bonzini, 2015/09/14
- Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag,
Stefano Stabellini <=
- Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag, Paolo Bonzini, 2015/09/15
- Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag, Chen, Tiejun, 2015/09/15
- Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag, Stefano Stabellini, 2015/09/17
- Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag, Peter Maydell, 2015/09/09
- Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag, Chen, Tiejun, 2015/09/09
- Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag, Peter Maydell, 2015/09/10
- Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag, Chen, Tiejun, 2015/09/10
- Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag, Stefano Stabellini, 2015/09/10
Re: [Qemu-devel] [Xen-devel] [PULL 0/19] xen-2015-09-08-tag, Chen, Tiejun, 2015/09/20