[Qemu-devel] Re: [PATCH] Fix build for mingw32 on windows ($@ in macro)

[Stefan Weil]

malc schrieb:
> On Thu, 19 Nov 2009, Stefan Weil wrote:
>
>> Make using mingw32 on windows does not preserve $@ in macros
>> when they are modified using this pattern:
>> target: macro += something
>>
>> This behaviour results in an error when QEMU_CFLAGS containing
>> "-MMD -MP -MT $@" is modified for compilation of source files
>> which use SDL: $@ will expand to nothing, -MT no longer has
>> the correct argument (it will take the next one from the command
>> line) and the build will fail or run with a wrong command line.
>>
>> The problem is fixed by using a new macro QEMU_DGFLAGS
>> which is not modified by a target rule.
>
> Why not just stuff `-MMD -MP -MT $@' into the rules?
>
> [..snip..]

As in most cases, there are many ways to do something...

During my test, I had the dependency flags in the rules.

I decided to use a macro to allow people running make
without dependency generation (make QEMU_DGFLAGS=).

Stefan