[Qemu-devel] Re: Build failure on mingw

[malc]

On Mon, 16 Nov 2009, Sebastian Herbszt wrote:

> malc wrote:
> > On Sat, 14 Nov 2009, Sebastian Herbszt wrote:

[..snip..]

> > 
> > Neither is/was correct, does escaping $@ in rules make (i.e. \$@) have
> > any effect?
> 
> Changing it to \$@ makes it compile again:
> 
> $ grep MMD rules.mak         QEMU_CFLAGS += -MMD -MP -MT \$@

[..snip..]

> gcc -I/home/sh/vm/qemu/v0.11.0-rc0-1630-g51cc2e7-nox-fixed/slirp
> -Wold-style-definition
> -I. -I/home/sh/vm/qemu/v0.11.0-rc0-1630-g51cc2e7-nox-fixed -U_FORTIFY_SOURCE
> -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE
> -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wendif-labels
> -Wwrite-strings
> -Wmissing-prototypes -fno-strict-aliasing -m32 -DWIN32_LEAN_AND_MEAN
> -DWINVER=0x501 -MMD -MP -MT   -I/mingw/include/SDL -D_GNU_SOURCE=1
> -Dmain=SDL_main -O2 -g -c -o audio/sdlaudio.o audio/sdlaudio.c

[..snip..]

> 
> The only difference i notice are more spaces:
> -MMD -MP -MT -I/mingw/include/SDL
> vs.
> -MMD -MP -MT   -I/mingw/include/SDL
> 

Makefile has this:

sdl.o audio/sdlaudio.o sdl_zoom.o baum.o: QEMU_CFLAGS += $(SDL_CFLAGS)

Which, i guess, doesn't play well with expansion of $@ in rules.mak.
I wonder what changes you will see by adding following to the rules.mak.

QEMU_CFLAGS := $(QEMU_CFLAGS) -MMD -MP -MT $@

-- 
mailto:address@hidden