[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH] Fix build for mingw32 on windows ($@ in macro)
From: |
Stefan Weil |
Subject: |
[Qemu-devel] [PATCH] Fix build for mingw32 on windows ($@ in macro) |
Date: |
Thu, 19 Nov 2009 20:07:52 +0100 |
Make using mingw32 on windows does not preserve $@ in macros
when they are modified using this pattern:
target: macro += something
This behaviour results in an error when QEMU_CFLAGS containing
"-MMD -MP -MT $@" is modified for compilation of source files
which use SDL: $@ will expand to nothing, -MT no longer has
the correct argument (it will take the next one from the command
line) and the build will fail or run with a wrong command line.
The problem is fixed by using a new macro QEMU_DGFLAGS
which is not modified by a target rule.
Signed-off-by: Stefan Weil <address@hidden>
---
rules.mak | 9 +++++----
1 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/rules.mak b/rules.mak
index 77a801b..16713ba 100644
--- a/rules.mak
+++ b/rules.mak
@@ -11,16 +11,17 @@ MAKEFLAGS += -rR
%.m:
%.mak:
-QEMU_CFLAGS += -MMD -MP -MT $@
+# Flags for dependency generation
+QEMU_DGFLAGS += -MMD -MP -MT $@
%.o: %.c $(GENERATED_HEADERS)
- $(call quiet-command,$(CC) $(QEMU_CFLAGS) $(CFLAGS) -c -o $@ $<," CC
$(TARGET_DIR)$@")
+ $(call quiet-command,$(CC) $(QEMU_CFLAGS) $(QEMU_DGFLAGS) $(CFLAGS) -c
-o $@ $<," CC $(TARGET_DIR)$@")
%.o: %.S
- $(call quiet-command,$(CC) $(QEMU_CFLAGS) $(CFLAGS) -c -o $@ $<," AS
$(TARGET_DIR)$@")
+ $(call quiet-command,$(CC) $(QEMU_CFLAGS) $(QEMU_DGFLAGS) $(CFLAGS) -c
-o $@ $<," AS $(TARGET_DIR)$@")
%.o: %.m
- $(call quiet-command,$(CC) $(QEMU_CFLAGS) $(CFLAGS) -c -o $@ $<," OBJC
$(TARGET_DIR)$@")
+ $(call quiet-command,$(CC) $(QEMU_CFLAGS) $(QEMU_DGFLAGS) $(CFLAGS) -c
-o $@ $<," OBJC $(TARGET_DIR)$@")
LINK = $(call quiet-command,$(CC) $(QEMU_CFLAGS) $(CFLAGS) $(LDFLAGS) -o $@
$(1) $(ARLIBS_BEGIN) $(ARLIBS) $(ARLIBS_END) $(LIBS)," LINK $(TARGET_DIR)$@")
--
1.5.6.5
- [Qemu-devel] Build failure on mingw, Sebastian Herbszt, 2009/11/14
- Message not available
- [Qemu-devel] Re: Build failure on mingw, Sebastian Herbszt, 2009/11/16
- [Qemu-devel] Re: Build failure on mingw, malc, 2009/11/16
- [Qemu-devel] Re: Build failure on mingw, Sebastian Herbszt, 2009/11/17
- [Qemu-devel] [PATCH] Fix build for mingw32 on windows ($@ in macro),
Stefan Weil <=
- [Qemu-devel] Re: [PATCH] Fix build for mingw32 on windows ($@ in macro), Sebastian Herbszt, 2009/11/19
- [Qemu-devel] Re: [PATCH] Fix build for mingw32 on windows ($@ in macro), malc, 2009/11/19
- [Qemu-devel] Re: [PATCH] Fix build for mingw32 on windows ($@ in macro), Stefan Weil, 2009/11/20
- Re: [Qemu-devel] [PATCH] Fix build for mingw32 on windows ($@ in macro), Jamie Lokier, 2009/11/19
- Re: [Qemu-devel] [PATCH] Fix build for mingw32 on windows ($@ in macro), Stefan Weil, 2009/11/20
- Re: [Qemu-devel] [PATCH] Fix build for mingw32 on windows ($@ in macro), Jamie Lokier, 2009/11/20
- Re: [Qemu-devel] [PATCH] Fix build for mingw32 on windows ($@ in macro), Stefan Weil, 2009/11/20
- Re: [Qemu-devel] [PATCH] Fix build for mingw32 on windows ($@ in macro), Sebastian Herbszt, 2009/11/20