[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 09/10] qdev: Use QError for 'device not found' e
From: |
Amit Shah |
Subject: |
Re: [Qemu-devel] [PATCH 09/10] qdev: Use QError for 'device not found' error |
Date: |
Fri, 20 Nov 2009 12:53:46 +0530 |
User-agent: |
Mutt/1.5.19 (2009-01-05) |
On (Wed) Nov 18 2009 [16:17:02], Markus Armbruster wrote:
> Luiz Capitulino <address@hidden> writes:
>
> > @@ -176,8 +177,7 @@ DeviceState *qdev_device_add(QemuOpts *opts)
> > /* find driver */
> > info = qdev_find_info(NULL, driver);
> > if (!info) {
> > - qemu_error("Device \"%s\" not found. Try -device '?' for a
> > list.\n",
> > - driver);
> > + qemu_error_new(QERR_DEVICE_NOT_FOUND, driver);
> > return NULL;
> > }
> > if (info->no_user) {
>
> Not obvious from this patch, but we lose the "Try -device '?' for a
> list" hint here. In PATCH 7/10:
BTW that hint isn't always appropriate as it's printed on the monitor
when doing 'device_add' as well.
Amit
- Re: [Qemu-devel] [PATCH 10/10] monitor: do_info_balloon(): use QError, (continued)
[Qemu-devel] [PATCH 08/10] monitor: QError support, Luiz Capitulino, 2009/11/17
[Qemu-devel] [PATCH 09/10] qdev: Use QError for 'device not found' error, Luiz Capitulino, 2009/11/17
Re: [Qemu-devel] [PATCH 00/10]: QError v4, Markus Armbruster, 2009/11/18
- Re: [Qemu-devel] [PATCH 00/10]: QError v4, Anthony Liguori, 2009/11/18
- Re: [Qemu-devel] [PATCH 00/10]: QError v4, Jamie Lokier, 2009/11/18
- Re: [Qemu-devel] [PATCH 00/10]: QError v4, Anthony Liguori, 2009/11/20
- Re: [Qemu-devel] [PATCH 00/10]: QError v4, Luiz Capitulino, 2009/11/20
- Re: [Qemu-devel] [PATCH 00/10]: QError v4, Anthony Liguori, 2009/11/20
- Re: [Qemu-devel] [PATCH 00/10]: QError v4, Markus Armbruster, 2009/11/20
Re: [Qemu-devel] [PATCH 00/10]: QError v4, Markus Armbruster, 2009/11/20
Re: [Qemu-devel] [PATCH 00/10]: QError v4, Anthony Liguori, 2009/11/20
Re: [Qemu-devel] [PATCH 00/10]: QError v4, Markus Armbruster, 2009/11/19