Re: PowerPC port of PUPA

[Marco Gerards]

Johan Rydberg <address@hidden> writes:

> : (I hope you do not receive this mail twice, gnus is doing weird stuff
> : here..)
> 
> I did.  But who cares?  I love getting mail. :)

LOL!

> : - Write iso9660fs.
> 
> This could should be sharable between architectures, shouldn't it?

Yes, it is.  I just mentioned it because this patch adds CDROM
support (with open firmware you get that for free).  It would be nice
if a distribution could put PUPA on the bootcd to load the installer,
etc.

> Just a few comments on the patch:
> 
> --- ../pupa/conf/powerpc-nwmac.rmk    1970-01-01 01:00:00.000000000 +0100
> +++ ./conf/powerpc-nwmac.rmk  2004-01-24 00:15:36.000000000 +0100
> @@ -0,0 +1,49 @@
> +
> +# -*- makefile -*-
> +
> +COMMON_ASFLAGS = -nostdinc -fno-builtin
> +COMMON_CFLAGS = -fno-builtin
> 
> Is there a reason for not having builtins?  Is it to eliminate the need
> for functions such as memcpy() and puts() (they do not live in the PUPA
> namespace) ?

Well, this make me think about another problem that I completely
haven't considered: You use alloca in your code.

> : +static void
> : +pupa_ofconsole_cls (void)
> : +{
> : +  /* Clear the screen.  */
> : +  pupa_ofconsole_writeesc ("");
> : +}
> 
> Please use pupa_ofconsole_writeesc ("\014"); or something similar. We do
> not want people to get a form feed right in a C stmt when they print the
> sources.

Right, I have not thought about that.  I will make this change.

Thanks,
Marco