Re: PowerPC port of PUPA

[Johan Rydberg]

Marco Gerards <address@hidden> wrote:

: Hi,
: 
: (I hope you do not receive this mail twice, gnus is doing weird stuff
: here..)

I did.  But who cares?  I love getting mail. :)

: - Write iso9660fs.

This could should be sharable between architectures, shouldn't it?

Just a few comments on the patch:

--- ../pupa/conf/powerpc-nwmac.rmk      1970-01-01 01:00:00.000000000 +0100
+++ ./conf/powerpc-nwmac.rmk    2004-01-24 00:15:36.000000000 +0100
@@ -0,0 +1,49 @@
+
+# -*- makefile -*-
+
+COMMON_ASFLAGS = -nostdinc -fno-builtin
+COMMON_CFLAGS = -fno-builtin

Is there a reason for not having builtins?  Is it to eliminate the need
for functions such as memcpy() and puts() (they do not live in the PUPA
namespace) ?

: +static void
: +pupa_ofconsole_cls (void)
: +{
: +  /* Clear the screen.  */
: +  pupa_ofconsole_writeesc ("");
: +}

Please use pupa_ofconsole_writeesc ("\014"); or something similar. We do
not want people to get a form feed right in a C stmt when they print the
sources.

-- 
Johan Rydberg, Free Software Developer, Sweden
http://rtmk.sf.net | http://www.nongnu.org/guss/

Playing Boards Of Canada - Kiteracer 2