Re: [Openvortex-dev] Re: Ryan's patch

[O.Sezer]

Hi Ryan:

> > In file included from au8810_mixer.c:2:
> > au88x0_mixer.c: In function `snd_vortex_mixer':
> > au88x0_mixer.c:20: warning: assignment from incompatible
> > pointer type
>
>
> Oops, looks like something didn't patch right.  I'll use a unified diff
> this time:
[SNIP]
> Yes, that should do exactly what Manuel's hack in *_mixer.c did before.
> Also, if your codec supports it, the DAC/ADC attentuation controls
> should also be there.  Removing codec hacks from the aureal driver and
> letting the generic ac97 support in alsa handle them seems like a better
> idea to me, since this driver will eventually be integrated with the
> alsa tree.

The only difference between your first and second patches is this:
diff -urN ryan1/pci/au88x0/au88x0_core.c ryan2/pci/au88x0/au88x0_core.c
--- ryan1/pci/au88x0/au88x0_core.c      2003-06-15 23:11:03.000000000 +0300
+++ ryan2/pci/au88x0/au88x0_core.c      2003-06-15 23:11:27.000000000 +0300
@@ -1986,7 +1986,7 @@

 void vortex_codec_wait(void) {

-       /* Perhaps move the reads from the write_codec() to here */
+       /* FIXME */

 }


So there's no change related to au88x0_mixer.c.

I'll try to test re-backing out the amplifier hack and see what the
volume does.

Thanks;
Özkan Sezer