[Octave-bug-tracker] [bug #54180] libinterp/corefcn/file-io.cc-tst failure and weird output when test suite is run twice

[John W. Eaton]

Follow-up Comment #10, bug #54180 (project octave):

Dan, your change is OK, but should probably use an unwind_protct block to also
avoid leaks in case there is an error in the test.  I think that's what we use
in other tests.

Checking for leaked resources in the function that runs tests for a given file
seems like a good change.  Other than the things mentioned in comment #9,
another thing to check for might be global variables.

I don't think you can check for leaked resources in a single %!test though,
because multiple tests may share the same open file, global variable, or other
resource.

Probably it should just be an error if there is a leak since it is an error in
the test suite.  If that turns out to cause too much trouble, then we could
make it something that is not fatal and is just reported in the summary like
other test failures.


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?54180>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/