[Octave-bug-tracker] [bug #54180] libinterp/corefcn/file-io.cc-tst failure and weird output when test suite is run twice

[Andrew Janke]

Follow-up Comment #9, bug #54180 (project octave):

I think this patch worked!

I rebuilt my Octave against it and ran __run_test_suite__ multiple times in a
session; the `file-io.cc-test` failure did not recur.

I did get other failures during my reruns:


  libinterp/corefcn/graphics.cc-tst ........................... PASS    
46/47
                                                                  FAIL    1
[...]

  image/getframe.m ............................................ PASS      1/2
                                                                  FAIL    1


>From fntests.log:


>>>>> processing
/Applications/Octave-4.4.0.app/Contents/Resources/usr/Cellar/octave-octave-app_4.4.0/4.4.0/share/octave/4.4.0/etc/tests/libinterp/corefcn/graphics.cc-tst
[...]
!!!!! test failed
ASSERT errors for:  assert (get (hf, "uicontextmenu"),[])

  Location  |  Observed  |  Expected  |  Reason
     .          O(1x1)       E(0x0)      Dimensions don't match
[...]
>>>>> processing
/Applications/Octave-4.4.0.app/Contents/Resources/usr/Cellar/octave-octave-app_4.4.0/4.4.0/share/octave/4.4.0/m/image/getframe.m
***** testif HAVE_QT_OFFSCREEN; have_window_system ()
 hf = figure ("visible", "off");
 unwind_protect
   hax = axes ("visible", "off", "position", [0 0 1 1]);
   verts = [0 0; .5 0; 1 0; ...
            0 .5; .5 .5; 1 .5; ...
            0 1; .5 1; 1 1];
   faces = [1 2 5 4; 2 3 6 5; 4 5 8 7; 5 6 9 8];
   fvc = [1 0 0; 0 1 0; 0 0 1; 1 0 1];
   patch ("vertices", verts, "faces", faces, "facevertexcdata", fvc, ...
          "facecolor", "flat");

   kk = 1;
   pos = get (hf, "position");

   for jj = [0.05 0.55]
     for ii = [0.05 0.55]
       rect = [ii jj .4 .4].*[pos(3:4) pos(3:4)];
       frame = getframe (hax, rect).cdata;
       assert (frame(:,:,1) == fvc(kk,1)*255);
       assert (frame(:,:,2) == fvc(kk,2)*255);
       assert (frame(:,:,3) == fvc(kk,3)*255);
       kk++;
     endfor
   endfor
 unwind_protect_cleanup
   close (hf);
 end_unwind_protect
!!!!! test failed
getframe: unable to retrieve figure pixels


Those look related to graphics support, not file handles. And maybe they're
because I was doing other things with my machine while the tests ran.

> Could you make that just one change within the test() function? 

I will make a patch to do this if I find some time.

Are there other global resources we should check for leakage of? Figure
handles? Open network ports?

Do you think it's appropriate to call error() to abort the tests in the case
of leakage? Or introduce a new "ERROR: ..." output to report them? Or
something else?

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?54180>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/