Re: Issue 4078: Doc: Use variables rather than instrument definitions (issue 138950043 by address@hidden)

[k-ohara5a5a]

still LGTM


https://codereview.appspot.com/138950043/diff/1/Documentation/notation/vocal.itely
File Documentation/notation/vocal.itely (right):

https://codereview.appspot.com/138950043/diff/1/Documentation/notation/vocal.itely#newcode2580
Documentation/notation/vocal.itely:2580: kaspar = {
On 2014/08/31 07:58:49, Trevor Daniels wrote:
> Personally I prefer just "kaspar" as snappier.

Keep it snappy, then.

https://codereview.appspot.com/138950043/diff/1/Documentation/notation/vocal.itely#newcode2646
Documentation/notation/vocal.itely:2646: \set instrumentCueName =
"Flute"
On 2014/08/31 07:58:49, Trevor Daniels wrote:
> This is using InstrumentSwitch in it's "proper"
> orchestral sense, where it's interacting with
> \cueDuring.  Changing that needs more thought, and
> needs to be done at the same time as the change to
> the corresponding section in staff.itely.

Whichever use of instrumentSwitch was its original intent, or whichever
use is proper, neither is useful.

I have the rest of the removal ready to follow after this patch.

https://codereview.appspot.com/138950043/