Re: Issue 4078: Doc: Use variables rather than instrument definitions (issue 138950043 by address@hidden)

[tdanielsmusic]

Reviewers: Keith, dak,

Message:
Thanks Keith.  Responses below.

Trevor



https://codereview.appspot.com/138950043/diff/1/Documentation/notation/vocal.itely
File Documentation/notation/vocal.itely (right):

https://codereview.appspot.com/138950043/diff/1/Documentation/notation/vocal.itely#newcode2580
Documentation/notation/vocal.itely:2580: kaspar = {
On 2014/08/31 06:58:47, Keith wrote:
> David, I think, suggested the name 'setKaspar' to reinforce the
concept that it
> contains Kaspar's staff-settings, as opposed to Kaspar's music.

Personally I prefer just "kaspar" as snappier.
It would typically be used multiple times, whereas
kasparMusic and kasparLyrics would be used only once.
Not something to die in the ditch for - I'll change it.

https://codereview.appspot.com/138950043/diff/1/Documentation/notation/vocal.itely#newcode2646
Documentation/notation/vocal.itely:2646: \set instrumentCueName =
"Flute"
On 2014/08/31 06:58:47, Keith wrote:
> This is the *other* use of instrumentSwitch,
> which I'll probably put back to a <>^\markup

This is using InstrumentSwitch in it's "proper"
orchestral sense, where it's interacting with
\cueDuring.  Changing that needs more thought, and
needs to be done at the same time as the change to
the corresponding section in staff.itely.

Description:
Issue 4078: Doc: Use variables rather than instrument definitions

  Using variables for switching character names in vocal music
  rather than instrument definitions is easier to understand,
  easier to set up and quicker to type.  It also frees up the
  use of instrument definitions so they may be tailored for
  better use in instrumental compositions.

  Remove the mention of \transposition.  This is never required
  in vocal music.

  Adjust references to match the changes.

Please review this at https://codereview.appspot.com/138950043/

Affected files (+22, -33 lines):
  M Documentation/notation/vocal.itely


Index: Documentation/notation/vocal.itely
diff --git a/Documentation/notation/vocal.itely  
b/Documentation/notation/vocal.itely
index  
912378ab0877cede4d7fa8d02fc0fc68d1a076bc..a86c0acbab70f4da7cc043c1ebd131d3d2daaa37  
100644
--- a/Documentation/notation/vocal.itely
+++ b/Documentation/notation/vocal.itely
@@ -2572,54 +2572,43 @@ c4^\markup \fontsize #1 \smallCaps Kaspar
 c c c
 @end lilypond

-Alternatively, if there are many character changes, it may be
-easier to set up @qq{instrument} definitions for each character at
-the top level so that @code{\instrumentSwitch} can be used to
-indicate each change.  As notes for vocal parts are usually entered
-at sounding pitch no instrument transposition is required, even
-when, as here, the tenor line is printed an octave higher.
+Alternatively, if there are many character changes, it may be easier
+to set up variables to hold the definitions for each character so
+that the switch of characters can be indicated easily and concisely.

 @lilypond[quote,verbatim]
-\addInstrumentDefinition #"kaspar"
-  #`((instrumentTransposition . ,(ly:make-pitch 0 0 0))
-     (shortInstrumentName . "Kas.")
-     (clefGlyph . "clefs.G")
-     (clefTransposition . -7)
-     (middleCPosition . 1)
-     (clefPosition . -2)
-     (instrumentCueName . ,(markup #:fontsize 1 #:smallCaps "Kaspar"))
-     (midiInstrument . "voice oohs"))
-
-\addInstrumentDefinition #"melchior"
-  #`((instrumentTransposition . ,(ly:make-pitch 0 0 0))
-     (shortInstrumentName . "Mel.")
-     (clefGlyph . "clefs.F")
-     (clefTransposition . 0)
-     (middleCPosition . 6)
-     (clefPosition . 2)
-     (instrumentCueName . ,(markup #:fontsize 1 #:smallCaps "Melchior"))
-     (midiInstrument . "choir aahs"))
+kaspar = {
+  \clef "G_8"
+  \set Staff.shortVocalName = "Kas."
+  \set Staff.midiInstrument = "voice oohs"
+  <>^\markup \smallCaps "Kaspar"
+}
+
+melchior = {
+  \clef "bass"
+  \set Staff.shortVocalName = "Mel."
+  \set Staff.midiInstrument = "choir aahs"
+  <>^\markup \smallCaps "Melchior"
+}

 \relative c' {
-  \instrumentSwitch "kaspar"
+  \kaspar
   c4 c c c
-  \instrumentSwitch "melchior"
+  \melchior
   a4 a a a
-  \instrumentSwitch "kaspar"
+  \kaspar
   c4 c c c
 }
 @end lilypond

 @seealso
+Learning Manual:
address@hidden pieces with variables}.
+
 Notation Reference:
address@hidden names},
address@hidden functions},
 @ref{Text},
 @ref{Text markup commands}.

-Extending LilyPond:
address@hidden construction in Scheme}.
-

 @node Musical cues
 @unnumberedsubsubsec Musical cues