|
| From: | lemzwerg |
| Subject: | Re: Provide some more smob functionality and use it (issue 135240043 by address@hidden) |
| Date: | Sun, 31 Aug 2014 16:45:37 +0000 |
LGTM. Very nice! This indeed feels more C++ now. https://codereview.appspot.com/135240043/diff/20001/scripts/auxiliar/smob-convert.sh File scripts/auxiliar/smob-convert.sh (right): https://codereview.appspot.com/135240043/diff/20001/scripts/auxiliar/smob-convert.sh#newcode2 scripts/auxiliar/smob-convert.sh:2: for i in $(git grep -l '^\s\+DECLARE_SIMPLE_SMOBS' lily) Will this script be ever used again? It perhaps deserves a comment... https://codereview.appspot.com/135240043/
| [Prev in Thread] | Current Thread | [Next in Thread] |