|
| From: | mtsolo |
| Subject: | Re: reorganize self_alignment_interface (issue 7768043) |
| Date: | Sat, 30 Mar 2013 18:15:12 +0000 |
In general, I see a lot of reassigning of parents. What is the goal with this (sorry if you've explained this already)? https://codereview.appspot.com/7768043/diff/38001/lily/fingering-engraver.cc File lily/fingering-engraver.cc (right): https://codereview.appspot.com/7768043/diff/38001/lily/fingering-engraver.cc#newcode142 lily/fingering-engraver.cc:142: Self_alignment_interface::aligned_on_x_parent (fingerings_[i]->self_scm ())); This needs to be a chained offset procedure. See chain_offset_callback elsewhere in the code. https://codereview.appspot.com/7768043/diff/38001/lily/paper-column.cc File lily/paper-column.cc (right): https://codereview.appspot.com/7768043/diff/38001/lily/paper-column.cc#newcode222 lily/paper-column.cc:222: /* Good work! https://codereview.appspot.com/7768043/
| [Prev in Thread] | Current Thread | [Next in Thread] |