Re: [libcvd-members] FAST corner detection--- RFC

[Edward Rosten]

> Sure, but it'll break everyone's existing code :)

True.


> The slightly uglier but more compatible alternative is to have a different
> function name which does all-in-one.

Such as a bool (with a default to no) to enable nonmax suppression?

> It's up to you IMO. The code breakage would be trivial to fix.
>
> By the way - am I correct in my vague recollection that the nonmax function 
> currently doesn't even know about the xx in fast-xx?

yes.

> I suppose your new formulation would fix that?

Yes.

> // wish list start
> If your new nonmax-suppression code will fix that, can you make standalone 
> versions of that as well?

Yep. You'll put in a list of image_ref's and scores and get out a list of 
image refs and  a list of scores (if you want it).

> And if it's faster, maybe even a version which 
> spits out both lists at once? Finally, a version which outputs 
> corners-and-scores would allow better dynamic thresholding.

You mean it spits out corners with scores, like the one you wrote and 
checked in? ;-)


> > How so? What machines does it fail on?
>
> It didn't on mine here for a while (core 2 duo) but now does. Any number of 
> things could have changed.

I don't have a core2 duo to test it on.


> > > that you are in fact getting the SCREAMING SIMD version if you want it. 
> > > Currently, the compile brekage if you don't accomplishes that.
> >
> > How so? It's supposed to use non SSE versions if it doesn't detect it.
>
> Was probably something broken on my end - I was getting link errors. Maybe 
> .so and .h out of sync for some reason, although that shouldn't be possible.

Odd. That could be the case.

-Ed