[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: cvs commitinfo - remote access issues - enforced code beautification

From: Larry Jones
Subject: Re: cvs commitinfo - remote access issues - enforced code beautification
Date: Thu, 21 Mar 2002 10:26:07 -0500 (EST)

Noel Yap writes:
> I think Greg is correct in his assessment.  My guess
> as to how keyword expansion works is that the client
> already knows how to expand the keywords without any
> help from the server.  This can be tested by creating
> a commitinfo script that would, say, empty out the
> file, then check the keywords on the client.

No, commit does a checkout to expand keywords -- see checkin.c starting
at the comment that says:

            /* The checkin succeeded.  If checking the file out again
               would not cause any changes, we are done.  Otherwise,
               we need to check out the file, which will change the
               modification time of the file.

               The only way checking out the file could cause any
               changes is if the file contains RCS keywords.  So we if
               we are not expanding RCS keywords, we are done.  */

However, I would have expected that checkout to send a diff, but it
appears that it actually sends the whole file, which makes the kludge in
question work.  It's also highly inefficient, so I wouldn't count on it
continuing to work in the future (although I, for one, don't have any
immediate plans to change it).

-Larry Jones

Aw Mom, you act like I'm not even wearing a bungee cord! -- Calvin

reply via email to

[Prev in Thread] Current Thread [Next in Thread]