[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: cvs commitinfo - remote access issues - enforced code beautification

From: Thomas S. Urban
Subject: Re: cvs commitinfo - remote access issues - enforced code beautification
Date: Wed, 20 Mar 2002 15:12:06 -0800
User-agent: Mutt/1.3.21i

On Wed, Mar 20, 2002 at 16:37:44 -0500, Greg A. Woods sent 1.4K bytes:
> The source code control tool is not the place to do the beautification.
> You might want to validate the code and reject a commit if it does not
> meet your coding standards, but you should not (and indeed with CVS, can
> not really) try to modify the file being committed in any way.

What do you mean by "can not really"?  I do some modification of
committed files with a script called from commitinfo.  I don't do
anything too severe - clean up trailing white space, add headers in some
instances, make sure files created by broken editors have a new line
before EOF, and one or two other small things.  I guess that qualifies
as mild beautification?  Anyway, I haven't noticed any problems with
this approach in the 6 months or so I've had it turned on.  Any problems
I should be looking for?



Arrakis teaches the attitude of the knife - chopping off what's
incomplete and saying: "Now it's complete because it's ended here."
                -- Muad'dib, "Dune"

reply via email to

[Prev in Thread] Current Thread [Next in Thread]