[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [STUMP][CONTRIB] Tag-based window management
From: |
Julian Stecklina |
Subject: |
Re: [STUMP][CONTRIB] Tag-based window management |
Date: |
Wed, 15 Apr 2009 16:57:57 +0200 |
User-agent: |
Gnus/5.101 (Gnus v5.10.10) |
Raskin Michael <address@hidden> writes:
> (defcommand window-tags (&optional (argwin nil)) ()
> "Show window tags"
> (let* ((win (or argwin (current-window)))
> (tags (xlib:get-property (window-xwin win) :STUMPWM_TAGS))
> (tagstring (utf8-to-string tags))
> (taglist
> (if tags (with-input-from-string (tagstream tagstring) (read
> tagstream)) nil)
> )
> )
> (if argwin taglist (message "Tags: ~{~%~a~}" taglist))))
Some general comments:
- You use READ without *READ-EVAL* bound to NIL. READ is generally a
bad idea for everything that is not a quick hack IMHO.
- A line with only a ) violates StumpWM's style.
- You use INTERN without binding *PACKAGE* to something sensible.
- Interned symbols are never garbage collected (unless
uninterned). Creating interned symbols at runtime and never disposing
of them is IMHO problematic. You could just as well use strings to
represent tags.
Regards,
--
Julian Stecklina
The day Microsoft makes something that doesn't suck is probably the day
they start making vacuum cleaners - Ernst Jan Plugge
- [STUMP][CONTRIB] Tag-based window management, Raskin Michael, 2009/04/14
- Re: [STUMP][CONTRIB] Tag-based window management,
Julian Stecklina <=
- [STUMP] [UPDATE]Re: Tag-based window management, Michael Raskin, 2009/04/15
- Re: [STUMP] [UPDATE]Re: Tag-based window management, Julian Stecklina, 2009/04/16
- Re: [STUMP] [UPDATE]Re: Tag-based window management, Michael Raskin, 2009/04/16
- Re: [STUMP] [UPDATE]Re: Tag-based window management, Vitaly Mayatskikh, 2009/04/16
- Re: [STUMP] [UPDATE]Re: Tag-based window management, Michael Raskin, 2009/04/16
- Re: [STUMP] [UPDATE]Re: Tag-based window management, Vitaly Mayatskikh, 2009/04/16
- Re: [STUMP] [UPDATE]Re: Tag-based window management, Michael Raskin, 2009/04/16
- Re: [STUMP] [UPDATE]Re: Tag-based window management, Julian Stecklina, 2009/04/16
- Re: [STUMP] [UPDATE]Re: Tag-based window management, Shawn Betts, 2009/04/16
- Re: [STUMP] [UPDATE]Re: Tag-based window management, Vitaly Mayatskikh, 2009/04/16