Re: [Simulavr-devel] [PATCH] Add BREAK-instruction, causes simulavr to halt.

[Stan Behrens]

Hi Petr,

On 05/01/12 21:39, Petr Hluzín wrote:
> Why does your patch add instructionBREAKJustExecuted to AvrDevice and
> then have the if() condition in AvrDevice::Step()?
> It would be easier to do the tracing in avr_op_BREAK::operator()() and
> return BREAK_POINT. Function AvrDevice::Step() and class AvrDevice
> would be left as is.
Yeah, this was what the first version of my patch did. I had to change
that, because the PC was not incremented this way. Result was, your
stuck at BREAK forever once you reach it.

Bye, Stan.