Re: [Simulavr-devel] [PATCH] Add BREAK-instruction, causes simulavr to halt.

[Petr Hluzín]

On 11 January 2012 21:51, Stan Behrens
<address@hidden> wrote:
> TODO: Check if execution is continuable on a real MCU.
> ---
>  src/avrdevice.cpp     |    6 ++----
>  src/decoder.cpp       |    9 +++++++++
>  src/decoder.h         |   19 +++++++++++++++++++
>  src/decoder_trace.cpp |    6 ++++++
>  4 files changed, 36 insertions(+), 4 deletions(-)
>
> ...

Great! Committed to repository [1].

I was thinking about the condition and I think it was bogus.

I think in general it is preferred to post a description and the patch
in the same mail, not separately. A reviewer may easily respond to
both motivation, description and the actual code.

[1] 
http://git.savannah.gnu.org/cgit/simulavr.git/commit/?id=fcf0943c606b44dc4aa1f889facc1df3aa21290f

-- 
Petr Hluzin