qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 1/8] migration: Do not use C99 // comments


From: Bihong Yu
Subject: Re: [PATCH v2 1/8] migration: Do not use C99 // comments
Date: Tue, 13 Oct 2020 21:20:11 +0800
User-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0

Thank you for your review. OK, I will try to rewrite the DPRINTF to use trace_ 
instead.

On 2020/10/13 17:39, Dr. David Alan Gilbert wrote:
> * Bihong Yu (yubihong@huawei.com) wrote:
>> Signed-off-by: Bihong Yu <yubihong@huawei.com>
>> Reviewed-by: Chuan Zheng <zhengchuan@huawei.com>
> 
> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> 
> another task at some point would be to rewrite the DPRINTF's in
> migration/block.c to use trace_ instead.
> 
>> ---
>>  migration/block.c | 2 +-
>>  migration/rdma.c  | 2 +-
>>  2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/migration/block.c b/migration/block.c
>> index 737b649..4b8576b 100644
>> --- a/migration/block.c
>> +++ b/migration/block.c
>> @@ -40,7 +40,7 @@
>>  #define MAX_IO_BUFFERS 512
>>  #define MAX_PARALLEL_IO 16
>>  
>> -//#define DEBUG_BLK_MIGRATION
>> +/* #define DEBUG_BLK_MIGRATION */
>>  
>>  #ifdef DEBUG_BLK_MIGRATION
>>  #define DPRINTF(fmt, ...) \
>> diff --git a/migration/rdma.c b/migration/rdma.c
>> index 0340841..0eb42b7 100644
>> --- a/migration/rdma.c
>> +++ b/migration/rdma.c
>> @@ -1288,7 +1288,7 @@ const char *print_wrid(int wrid)
>>   * workload information or LRU information is available, do not attempt to 
>> use
>>   * this feature except for basic testing.
>>   */
>> -//#define RDMA_UNREGISTRATION_EXAMPLE
>> +/* #define RDMA_UNREGISTRATION_EXAMPLE */
>>  
>>  /*
>>   * Perform a non-optimized memory unregistration after every transfer
>> -- 
>> 1.8.3.1
>>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]