qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 3/8] migration: Add spaces around operator


From: Bihong Yu
Subject: Re: [PATCH v2 3/8] migration: Add spaces around operator
Date: Tue, 20 Oct 2020 10:47:07 +0800
User-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0

OK, I will change it to "VMStateDescription *[]". Thank you for your review.

On 2020/10/19 19:59, Markus Armbruster wrote:
> Bihong Yu <yubihong@huawei.com> writes:
> 
>> Yes, I used to think "const VMStateDescription *[]" was right, but when I 
>> search
>> similar expressions, most of all are "xxx * []". Such as:
>> fsdev/qemu-fsdev.c:54:        .opts = (const char * [])
>> hw/intc/s390_flic_kvm.c:567:    .subsections = (const VMStateDescription * 
>> [])
>> ...
> 
> All three variations occur in the code: no space, space on both sides,
> space only on the left.
> 
>> So, I keep the same style. Should I change it to "const VMStateDescription 
>> *[]"?
> 
> Dropping the change to savevm.c should be fine.
> 
> Changing it to "VMStateDescription *[]" should be also fine.
> 
> I figure you can keep David's R-by in both cases.
> 
> [...]
> 
> .
> 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]