qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 6/8] migration: Do not initialise statics and globals to 0


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v2 6/8] migration: Do not initialise statics and globals to 0 or NULL
Date: Tue, 20 Oct 2020 08:50:01 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1

On 10/14/20 9:21 PM, Dr. David Alan Gilbert wrote:
* Bihong Yu (yubihong@huawei.com) wrote:
Signed-off-by: Bihong Yu <yubihong@huawei.com>
Reviewed-by: Chuan Zheng <zhengchuan@huawei.com>

OK, sometimes  I find initialisation clearer


Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>

---
  migration/ram.c    | 2 +-
  migration/savevm.c | 2 +-
  2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/migration/ram.c b/migration/ram.c
index 09178cc..2da2b62 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -2743,7 +2743,7 @@ static int load_xbzrle(QEMUFile *f, ram_addr_t addr, void 
*host)
   */
  static inline RAMBlock *ram_block_from_stream(QEMUFile *f, int flags)
  {
-    static RAMBlock *block = NULL;
+    static RAMBlock *block;

OK.

      char id[256];
      uint8_t len;
diff --git a/migration/savevm.c b/migration/savevm.c
index 9e95df1..f808bc2 100644
--- a/migration/savevm.c
+++ b/migration/savevm.c
@@ -64,7 +64,7 @@
  #include "qemu/bitmap.h"
  #include "net/announce.h"
-const unsigned int postcopy_ram_discard_version = 0;
+const unsigned int postcopy_ram_discard_version;

I agree with Dave, this one is clearer initialized.

/* Subcommands for QEMU_VM_COMMAND */
  enum qemu_vm_cmd {
--
1.8.3.1





reply via email to

[Prev in Thread] Current Thread [Next in Thread]