Re: [PATCH] target/s390x/tcg/mem_helper: Remove bad assert() statement

[David Hildenbrand]

On 17.03.23 14:57, Thomas Huth wrote:
> The "assert(!nonfault)" statement can be triggered by running the
> "mvpg" s390x kvm-unit-test with TCG. According to Richard: "... the
> assert looks backward. We should only arrive there if nonfault was
> true for the probe (otherwise the probe would have raised the
> exception directly).  I would think we could just remove the assert."
>
> Fixes: 4049431478 ("target/s390x: Fix s390_probe_access for user-only")
> Suggested-by: Richard Henderson <richard.henderson@linaro.org>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---

Reviewed-by: David Hildenbrand <david@redhat.com>


--
Thanks,

David / dhildenb