[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] target/s390x/tcg/mem_helper: Remove bad assert() statement

From: Richard Henderson
Subject: Re: [PATCH] target/s390x/tcg/mem_helper: Remove bad assert() statement
Date: Fri, 17 Mar 2023 07:33:07 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0

On 3/17/23 06:57, Thomas Huth wrote:
The "assert(!nonfault)" statement can be triggered by running the
"mvpg" s390x kvm-unit-test with TCG. According to Richard: "... the
assert looks backward. We should only arrive there if nonfault was
true for the probe (otherwise the probe would have raised the
exception directly).  I would think we could just remove the assert."

Fixes: 4049431478 ("target/s390x: Fix s390_probe_access for user-only")
Suggested-by: Richard Henderson<richard.henderson@linaro.org>
Signed-off-by: Thomas Huth<thuth@redhat.com>
  target/s390x/tcg/mem_helper.c | 1 -
  1 file changed, 1 deletion(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


reply via email to

[Prev in Thread] Current Thread [Next in Thread]