[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [Qemu-devel] [PATCH 11/34] target/ppc: introduce get_fpr(

From: Mark Cave-Ayland
Subject: Re: [Qemu-ppc] [Qemu-devel] [PATCH 11/34] target/ppc: introduce get_fpr() and set_fpr() helpers for FP register access
Date: Thu, 20 Dec 2018 16:52:05 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0

On 19/12/2018 12:29, Mark Cave-Ayland wrote:

> On 19/12/2018 06:15, David Gibson wrote:
>> On Mon, Dec 17, 2018 at 10:38:48PM -0800, Richard Henderson wrote:
>>> From: Mark Cave-Ayland <address@hidden>
>>> These helpers allow us to move FP register values to/from the specified 
>>> TCGv_i64
>>> argument in the VSR helpers to be introduced shortly.
>>> To prevent FP helpers accessing the cpu_fpr array directly, add extra TCG
>>> temporaries as required.
>>> Signed-off-by: Mark Cave-Ayland <address@hidden>
>>> Message-Id: <address@hidden>
>> Acked-by: David Gibson <address@hidden>
>> Do you want me to take these, or will you take them via your tree?
> Well as discussed yesterday with Richard, I've already found another couple 
> of bugs
> in this version: a sign-extension bug, plus some leaking temporaries so there 
> will at
> least need to be a v3 of my patches.
> I'm wondering if it makes sense for me to pass the 2 vector operation 
> conversion
> patches over to Richard, and for you to take my v3 patchset that does all the
> groundwork separately first?

So this is the approach I've gone for - I've dropped my TCG vector conversion 
from the previous iteration, and posted v3 with all my latest fixes as a 
"prepare for conversion to TCG vector operations" patchset.

Richard - I've rebased your "tcg, target/ppc vector improvements" patchset on 
top of
my v3 patchset and pushed to 
to make it easier for us both to test.

Note that the 2 TCG vector conversion patches I originally created for v2 are 
included as part of your patchset instead (including a squash of your 
nand, nor, eqv are now generic vector operations" patch).



reply via email to

[Prev in Thread] Current Thread [Next in Thread]