[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [Qemu-devel] [PATCH 4/4] spapr: Add support for time base

From: Alexander Graf
Subject: Re: [Qemu-ppc] [Qemu-devel] [PATCH 4/4] spapr: Add support for time base offset migration
Date: Mon, 14 Apr 2014 08:32:49 +0200
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:24.0) Gecko/20100101 Thunderbird/24.4.0

On 13.04.14 07:56, Benjamin Herrenschmidt wrote:
On Sun, 2014-04-13 at 00:38 +0100, Peter Maydell wrote:
 From a design standpoint I find that totally retarded btw :-)
I agree it's bonkers; it's just that fixing it requires a big pile
of design and implementation work from somebody; and in
the meantime "both ends must be configured identically" is
at least a consistent and coherent position...
Sure I'm fine with that. I was just advocating for putting the TB
value in the stream so we can barf if it differs but I don't care
*that* much if it's not there.

I think on some chips it might be configurable so it won't hurt....

So for chips that might be configurable, configuration has to happen via some SPR, right? Wouldn't it make sense to transfer that configuration SPR on these and thus the configuration as well?

Really, the main problem I see with adding the tb frequency into the migration stream is that we'd change the migration format. Worst case it would be a few useless bytes on migration - not a big deal. But I don't think we support any case where it would actually be required - it'd only be a safety net.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]