Re: [PATCH 2/2] system/qtest: Restrict QTest API to system emulation

[Thomas Huth]

On 12/12/2023 12.30, Philippe Mathieu-Daudé wrote:
> Outside of system emulation, only qtest_enabled() can be used.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   include/sysemu/qtest.h | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/include/sysemu/qtest.h b/include/sysemu/qtest.h
> index 85f05b0e46..b5d5fd3463 100644
> --- a/include/sysemu/qtest.h
> +++ b/include/sysemu/qtest.h
> @@ -23,6 +23,7 @@ static inline bool qtest_enabled(void)
>       return qtest_allowed;
>   }
>   
> +#ifndef CONFIG_USER_ONLY
>   void qtest_send_prefix(CharBackend *chr);
>   void G_GNUC_PRINTF(2, 3) qtest_sendf(CharBackend *chr, const char *fmt, ...);
>   void qtest_set_command_cb(bool (*pc_cb)(CharBackend *chr, gchar **words));
> @@ -35,5 +36,6 @@ void qtest_server_set_send_handler(void (*send)(void *, const 
> char *),
>   void qtest_server_inproc_recv(void *opaque, const char *buf);
>   
>   int64_t qtest_get_virtual_clock(void);
> +#endif

Reviewed-by: Thomas Huth <thuth@redhat.com>