|
From: | Christian Borntraeger |
Subject: | Re: [PATCH 3/4] hw/s390x/ipl: Remove unused 'exec/exec-all.h' included header |
Date: | Tue, 12 Dec 2023 14:08:33 +0100 |
User-agent: | Mozilla Thunderbird |
Am 12.12.23 um 12:36 schrieb Philippe Mathieu-Daudé:
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> --- hw/s390x/ipl.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/s390x/ipl.c b/hw/s390x/ipl.c index 515dcf51b5..62182d81a0 100644 --- a/hw/s390x/ipl.c +++ b/hw/s390x/ipl.c @@ -35,7 +35,6 @@ #include "qemu/cutils.h" #include "qemu/option.h" #include "standard-headers/linux/virtio_ids.h" -#include "exec/exec-all.h"
Philippe, This include came with commit a30fb811cbe940020a498d2cdac9326cac38b4d9 Author: David Hildenbrand <david@redhat.com> AuthorDate: Tue Apr 24 12:18:59 2018 +0200 Commit: Cornelia Huck <cohuck@redhat.com> CommitDate: Mon May 14 17:10:02 2018 +0200 s390x: refactor reset/reipl handling And I think one reason was cpu_loop_exit This is still part of ipl.c a30fb811cbe (David Hildenbrand 2018-04-24 12:18:59 +0200 664) /* as this is triggered by a CPU, make sure to exit the loop */ a30fb811cbe (David Hildenbrand 2018-04-24 12:18:59 +0200 665) if (tcg_enabled()) { a30fb811cbe (David Hildenbrand 2018-04-24 12:18:59 +0200 666) cpu_loop_exit(cs); a30fb811cbe (David Hildenbrand 2018-04-24 12:18:59 +0200 667) } So why do you think exec-all.h is unused?
[Prev in Thread] | Current Thread | [Next in Thread] |