Re: [PATCH 1/2] system/qtest: Include missing 'hw/core/cpu.h' header

[Thomas Huth]

On 12/12/2023 12.30, Philippe Mathieu-Daudé wrote:
> "hw/core/cpu.h" declares 'first_cpu'. Include it to avoid
> when unrelated headers are refactored:
>
>    system/qtest.c:548:33: error: use of undeclared identifier 'first_cpu'
>              address_space_write(first_cpu->as, addr, MEMTXATTRS_UNSPECIFIED,
>                                  ^
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   system/qtest.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/system/qtest.c b/system/qtest.c
> index 7964f0b248..6da58b3874 100644
> --- a/system/qtest.c
> +++ b/system/qtest.c
> @@ -21,6 +21,7 @@
>   #include "exec/tswap.h"
>   #include "hw/qdev-core.h"
>   #include "hw/irq.h"
> +#include "hw/core/cpu.h"
>   #include "qemu/accel.h"
>   #include "sysemu/cpu-timers.h"
>   #include "qemu/config-file.h"

Reviewed-by: Thomas Huth <thuth@redhat.com>