Re: [PATCH v3 04/10] linux-user: Add '-one-insn-per-tb' option equivalent to '-singlestep'

[Philippe Mathieu-Daudé]

On 17/4/23 18:40, Peter Maydell wrote:
> The '-singlestep' option is confusing, because it doesn't actually
> have anything to do with single-stepping the CPU. What it does do
> is force TCG emulation to put one guest instruction in each TB,
> which can be useful in some situations.
>
> Create a new command line argument -one-insn-per-tb, so we can
> document that -singlestep is just a deprecated synonym for it,
> and eventually perhaps drop it.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> Reviewed-by: Warner Losh <imp@bsdimp.com>
> ---
>   docs/user/main.rst | 7 ++++++-
>   linux-user/main.c  | 9 ++++++---
>   2 files changed, 12 insertions(+), 4 deletions(-)


> @@ -500,8 +500,11 @@ static const struct qemu_argument arg_table[] = {
>        "logfile",     "write logs to 'logfile' (default stderr)"},
>       {"p",          "QEMU_PAGESIZE",    true,  handle_arg_pagesize,
>        "pagesize",   "set the host page size to 'pagesize'"},
> -    {"singlestep", "QEMU_SINGLESTEP",  false, handle_arg_singlestep,
> -     "",           "run in singlestep mode"},
> +    {"one-insn-per-tb",
> +                   "QEMU_ONE_INSN_PER_TB",  false, handle_arg_one_insn_per_tb,
> +     "",           "run with one guest instruction per emulated TB"},
> +    {"singlestep", "QEMU_SINGLESTEP",  false, handle_arg_one_insn_per_tb,
> +     "",           "deprecated synonym for -one-insn-per-tb"},

Maybe worth mentioning QEMU_ONE_INSN_PER_TB too here:

  "deprecated synonyms for -one-insn-per-tb and QEMU_ONE_INSN_PER_TB"

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

>       {"strace",     "QEMU_STRACE",      false, handle_arg_strace,
>        "",           "log system calls"},
>       {"seed",       "QEMU_RAND_SEED",   true,  handle_arg_seed,