Re: [PATCH v3 07/10] accel/tcg: Report one-insn-per-tb in 'info jit', not 'info status'

[Philippe Mathieu-Daudé]

On 17/4/23 18:40, Peter Maydell wrote:
> Currently we report whether the TCG accelerator is in
> 'one-insn-per-tb' mode in the 'info status' output.  This is a pretty
> minor piece of TCG specific information, and we want to deprecate the
> 'singlestep' field of the associated QMP command.  Move the
> 'one-insn-per-tb' reporting to 'info jit'.
>
> We don't need a deprecate-and-drop period for this because the
> HMP interface has no stability guarantees.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> The new 'accelerator settings' subsection of the output
> currently only has one item, but it would be a place to put
> other stuff, eg if we wanted to mention whether split-wx is
> enabled.

Ideally we should have a AccelClass::qmp_query_info() handler
optionally implemented by accelerators, and a single HMP 'info accel'
which convert the QMP handler result to human text.

This is a start :)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

> ---
>   accel/tcg/monitor.c         | 14 ++++++++++++++
>   softmmu/runstate-hmp-cmds.c |  5 ++---
>   2 files changed, 16 insertions(+), 3 deletions(-)