Re: [PATCH v7 02/12] target/riscv/cpu.c: remove set_vext

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v7 02/12] target/riscv/cpu.c: remove set_vext_version()

From:	Daniel Henrique Barboza
Subject:	Re: [PATCH v7 02/12] target/riscv/cpu.c: remove set_vext_version()
Date:	Thu, 20 Apr 2023 06:12:21 -0300
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0



On 4/19/23 20:37, Alistair Francis wrote:

On Tue, Apr 18, 2023 at 12:08 AM Daniel Henrique Barboza
<dbarboza@ventanamicro.com> wrote:


This setter is doing nothing else but setting env->vext_ver. Assign the
value directly.

Signed-off-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
Reviewed-by: LIU Zhiwei <zhiwei_liu@linux.alibaba.com>
Reviewed-by: Weiwei Li <liweiwei@iscas.ac.cn>


I think you dropped my previous reviews


Ops! My bad!


I'll re-send with your acks.


Daniel


Alistair

---
  target/riscv/cpu.c | 7 +------
  1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c
index feca13aefb..fed7b467e4 100644
--- a/target/riscv/cpu.c
+++ b/target/riscv/cpu.c
@@ -252,11 +252,6 @@ static void set_priv_version(CPURISCVState *env, int 
priv_ver)
      env->priv_ver = priv_ver;
  }

-static void set_vext_version(CPURISCVState *env, int vext_ver)
-{
-    env->vext_ver = vext_ver;
-}
-
  #ifndef CONFIG_USER_ONLY
  static uint8_t satp_mode_from_str(const char *satp_mode_str)
  {
@@ -834,7 +829,7 @@ static void riscv_cpu_validate_v(CPURISCVState *env, 
RISCVCPUConfig *cfg,
          qemu_log("vector version is not specified, "
                   "use the default value v1.0\n");
      }
-    set_vext_version(env, vext_version);
+    env->vext_ver = vext_version;
  }

  /*
--
2.39.2

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH v7 00/12] target/riscv: rework CPU extensions validation, Daniel Henrique Barboza, 2023/04/17
- [PATCH v7 01/12] target/riscv/cpu.c: add riscv_cpu_validate_v(), Daniel Henrique Barboza, 2023/04/17
  - Re: [PATCH v7 01/12] target/riscv/cpu.c: add riscv_cpu_validate_v(), Alistair Francis, 2023/04/19
- [PATCH v7 03/12] target/riscv/cpu.c: remove set_priv_version(), Daniel Henrique Barboza, 2023/04/17
- [PATCH v7 02/12] target/riscv/cpu.c: remove set_vext_version(), Daniel Henrique Barboza, 2023/04/17
  - Re: [PATCH v7 02/12] target/riscv/cpu.c: remove set_vext_version(), Alistair Francis, 2023/04/19
    - Re: [PATCH v7 02/12] target/riscv/cpu.c: remove set_vext_version(), Daniel Henrique Barboza <=
- [PATCH v7 04/12] target/riscv: add PRIV_VERSION_LATEST, Daniel Henrique Barboza, 2023/04/17
- [PATCH v7 05/12] target/riscv: Mask the implicitly enabled extensions in isa_string based on priv version, Daniel Henrique Barboza, 2023/04/17
- [PATCH v7 06/12] target/riscv: Update check for Zca/Zcf/Zcd, Daniel Henrique Barboza, 2023/04/17
- [PATCH v7 07/12] target/riscv/cpu.c: add priv_spec validate/disable_exts helpers, Daniel Henrique Barboza, 2023/04/17
- [PATCH v7 11/12] target/riscv: rework write_misa(), Daniel Henrique Barboza, 2023/04/17
- [PATCH v7 08/12] target/riscv/cpu.c: add riscv_cpu_validate_misa_mxl(), Daniel Henrique Barboza, 2023/04/17
- [PATCH v7 09/12] target/riscv/cpu.c: validate extensions before riscv_timer_init(), Daniel Henrique Barboza, 2023/04/17
- [PATCH v7 10/12] target/riscv/cpu.c: remove cfg setup from riscv_cpu_init(), Daniel Henrique Barboza, 2023/04/17
- [PATCH v7 12/12] target/riscv: forbid write_misa() for static CPUs, Daniel Henrique Barboza, 2023/04/17

Prev by Date: Re: [PATCH] igb: packet-split descriptors support
Next by Date: Re: [PATCH v3 04/10] linux-user: Add '-one-insn-per-tb' option equivalent to '-singlestep'
Previous by thread: Re: [PATCH v7 02/12] target/riscv/cpu.c: remove set_vext_version()
Next by thread: [PATCH v7 04/12] target/riscv: add PRIV_VERSION_LATEST
Index(es):
- Date
- Thread