[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH 18/40] igb: Remove goto
|
From: |
Sriram Yagnaraman |
|
Subject: |
RE: [PATCH 18/40] igb: Remove goto |
|
Date: |
Sat, 15 Apr 2023 19:08:40 +0000 |
> -----Original Message-----
> From: Akihiko Odaki <akihiko.odaki@daynix.com>
> Sent: Friday, 14 April 2023 13:37
> Cc: Sriram Yagnaraman <sriram.yagnaraman@est.tech>; Jason Wang
> <jasowang@redhat.com>; Dmitry Fleytman <dmitry.fleytman@gmail.com>;
> Michael S. Tsirkin <mst@redhat.com>; Alex Bennée <alex.bennee@linaro.org>;
> Philippe Mathieu-Daudé <philmd@linaro.org>; Thomas Huth
> <thuth@redhat.com>; Wainer dos Santos Moschetta
> <wainersm@redhat.com>; Beraldo Leal <bleal@redhat.com>; Cleber Rosa
> <crosa@redhat.com>; Laurent Vivier <lvivier@redhat.com>; Paolo Bonzini
> <pbonzini@redhat.com>; qemu-devel@nongnu.org; Akihiko Odaki
> <akihiko.odaki@daynix.com>
> Subject: [PATCH 18/40] igb: Remove goto
>
> The goto is a bit confusing as it changes the control flow only if L4
> protocol is
> not recognized. It is also different from e1000e, and noisy when comparing
> e1000e and igb.
>
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Reviewed-by: Sriram Yagnaraman <sriram.yagnaraman@est.tech>
- [PATCH 13/40] net/eth: Rename eth_setup_vlan_headers_ex, (continued)
- [PATCH 13/40] net/eth: Rename eth_setup_vlan_headers_ex, Akihiko Odaki, 2023/04/14
- [PATCH 14/40] e1000x: Share more Rx filtering logic, Akihiko Odaki, 2023/04/14
- [PATCH 15/40] e1000x: Take CRC into consideration for size check, Akihiko Odaki, 2023/04/14
- [PATCH 16/40] e1000e: Always log status after building rx metadata, Akihiko Odaki, 2023/04/14
- [PATCH 17/40] igb: Always log status after building rx metadata, Akihiko Odaki, 2023/04/14
- [PATCH 18/40] igb: Remove goto, Akihiko Odaki, 2023/04/14
- RE: [PATCH 18/40] igb: Remove goto,
Sriram Yagnaraman <=
- [PATCH 20/40] e1000e: Reset packet state after emptying Tx queue, Akihiko Odaki, 2023/04/14
- [PATCH 19/40] igb: Read DCMD.VLE of the first Tx descriptor, Akihiko Odaki, 2023/04/14
- [PATCH 22/40] igb: Add more definitions for Tx descriptor, Akihiko Odaki, 2023/04/14
- [PATCH 23/40] igb: Share common VF constants, Akihiko Odaki, 2023/04/14
- [PATCH 21/40] vmxnet3: Reset packet state after emptying Tx queue, Akihiko Odaki, 2023/04/14
- [PATCH 24/40] igb: Fix igb_mac_reg_init alignment, Akihiko Odaki, 2023/04/14