Re: [PATCH 17/40] igb: Always log status after building rx metadata

[Philippe Mathieu-Daudé]

On 14/4/23 13:37, Akihiko Odaki wrote:
> Without this change, the status flags may not be traced e.g. if checksum
> offloading is disabled.
>
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> ---
>   hw/net/igb_core.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

> diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c
> index 5fdc8bc42d..ccc5a626b4 100644
> --- a/hw/net/igb_core.c
> +++ b/hw/net/igb_core.c
> @@ -1303,9 +1303,8 @@ igb_build_rx_metadata(IGBCore *core,
>           trace_e1000e_rx_metadata_l4_cso_disabled();
>       }
>   
> -    trace_e1000e_rx_metadata_status_flags(*status_flags);
> -
>   func_exit:
> +    trace_e1000e_rx_metadata_status_flags(*status_flags);
>       *status_flags = cpu_to_le32(*status_flags);
>   }
>   

So igb_build_rx_metadata() is very similar to
e1000e_build_rx_metadata()...