Re: [PATCH v3 3/3] target/riscv: add TYPE_RISCV_DYNAMIC_CPU

[Richard Henderson]

On 4/11/23 20:35, Daniel Henrique Barboza wrote:
> This new abstract type will be used to differentiate between static and
> non-static CPUs in query-cpu-definitions.
>
> All generic CPUs were changed to be of this type. Named CPUs are kept as
> TYPE_RISCV_CPU and will still be considered static.
>
> This is the output of query-cpu-definitions after this change for the
> riscv64 target:
>
> $ ./build/qemu-system-riscv64 -S -M virt -display none -qmp stdio
> {"QMP": {"version": (...)}
> {"execute": "qmp_capabilities", "arguments": {"enable": ["oob"]}}
> {"return": {}}
> {"execute": "query-cpu-definitions"}
> {"return": [
> {"name": "rv64", "typename": "rv64-riscv-cpu", "static": false, "deprecated": 
> false},
> {"name": "sifive-e51", "typename": "sifive-e51-riscv-cpu", "static": true, 
> "deprecated": false},
> {"name": "any", "typename": "any-riscv-cpu", "static": false, "deprecated": 
> false},
> {"name": "x-rv128", "typename": "x-rv128-riscv-cpu", "static": false, 
> "deprecated": false},
> {"name": "shakti-c", "typename": "shakti-c-riscv-cpu", "static": true, 
> "deprecated": false},
> {"name": "thead-c906", "typename": "thead-c906-riscv-cpu", "static": true, 
> "deprecated": false},
> {"name": "sifive-u54", "typename": "sifive-u54-riscv-cpu", "static": true, 
> "deprecated": false}
> ]}
>
> Suggested-by: Richard Henderson<richard.henderson@linaro.org>
> Signed-off-by: Daniel Henrique Barboza<dbarboza@ventanamicro.com>
> ---
>   target/riscv/cpu-qom.h        |  2 +-
>   target/riscv/cpu.c            | 20 ++++++++++++++++----
>   target/riscv/riscv-qmp-cmds.c |  4 ++++
>   3 files changed, 21 insertions(+), 5 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~